#59 refactor assisted labeling notebook #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a litle bug, in some datasets "tax deduction" was not converted to "tax benefits"
Fine-tuning small bugs
rsmath
approved these changes
Jul 1, 2021
thefirebanks
requested changes
Jul 2, 2021
There was a problem hiding this comment.
Glad to see that we can finally merge this, good job! Before that, a couple of things here:
- I see that we have 5 notebooks named
Final_assisted_labelingwith different numbers at the end, but it seems that only one of them has been run and there's not much of a difference across all of them. Do we still need to keep the other 4 replicas or is it enough to just have 1? - I see that we have 2 versions of the file
Labeled_data_preparation, one of them inassisted_labelingand the other one inzero_shot_classification. Are both of them needed? What is each of them for? - What is the difference between
Assisted_labelingandFinal_assisted_labeling? If only one of them is the one we ended up using, let's keep that one and moveAssisted_labelingto theold_files_and_foldersfolder.
| @@ -35,3 +35,29 @@ def labeled_sentences_from_json(sents_json): | |||
| """ | |||
| return {sent_id: sent_labels_map for sent_id, sent_labels_map in [*sents_json.values()][0]["sentences"].items()} | |||
|
|
|||
There was a problem hiding this comment.
I think you forgot to define the function here? Because you wrote the comments and the code within the labeled_sentences_from_json method and after a return statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.