Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding mutation test #206

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Expanding mutation test #206

merged 2 commits into from
Jan 29, 2024

Conversation

mmikita95
Copy link
Contributor

Adding a class method to count initial mutations for a StateProxy. Checking the amount of mutations per each step of the test to ensure that mutations are properly tracked.

In regards to our prior discussion with @ramedina86, I found that the most reliable way to avoid issues like #198 in the future is to consistently track how many mutations are produced by the get_mutations_as_dict method in StateProxy, and compare the amount to the "ground truth" (i.e. actual number of mutations, which is easily deductible). I updated the mutation test to do exactly that. A method that counts expected "initial mutations" was also added, to make the test independent from the state of the dictionary initially passed to TestStateProxy.

I will be considering designing other tests as well, and any feedback is appreciated on the way.

Adding a class method to count initial mutations for a StateProxy. Checking the amount of mutations per each step of the test to ensure that mutations are properly tracked.
@ramedina86
Copy link
Collaborator

Nice tests! I'm not a hardcore test fanatic, but for these specific matters they're really helpful.

@ramedina86 ramedina86 merged commit b5efa74 into writer:dev Jan 29, 2024
@mmikita95 mmikita95 deleted the tests-update branch February 15, 2024 18:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants