Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare UI component handling for enhanced session and CMC integration #258

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

mmikita95
Copy link
Contributor

  • Include session-specific component tree in EventResponse payload
  • Update SessionComponentTree.to_dict to properly merge session-specific and base components, prioritizing session-specific ones
  • Add optional flag attribute to Component class for CMC control
  • Extend frontend Component type with flag property
  • Implement Component.from_dict class method to enable deserialization
  • Introduce frontend core logic to update components based on backend session tree data

…egration

- Include session-specific component tree in EventResponse payload
- Update SessionComponentTree.to_dict to properly merge session-specific and base components, prioritizing session-specific ones
- Add optional `flag` attribute to Component class for CMC control
- Extend frontend Component type with `flag` property
- Implement Component.from_dict class method to enable deserialization
- Introduce frontend core logic to update components based on backend session tree data
@mmikita95 mmikita95 marked this pull request as ready for review February 26, 2024 08:07
@mmikita95
Copy link
Contributor Author

Been testing this locally, and the only thing I could find are some builder-related glitches – but, as we're making CMCs non-editable this way, it'll be addressed.

src/streamsync/core.py Outdated Show resolved Hide resolved
src/streamsync/core.py Outdated Show resolved Hide resolved
ui/src/core/index.ts Outdated Show resolved Hide resolved
ui/src/core/index.ts Outdated Show resolved Hide resolved
src/streamsync/core.py Outdated Show resolved Hide resolved
- Renames updateComponents to ingestComponents in ui/core/index.ts
- Updates comment and variable name for sendComponent Update
- Refactors to_dict method of SessionComponentTree in core.py for readability
BREAKING CHANGE: Pydantic may potentionally interfere with how components are loaded on backend
tests/testapp/ui.json Outdated Show resolved Hide resolved
@ramedina86 ramedina86 merged commit a36f5ec into writer:dev Mar 1, 2024
12 checks passed
@mmikita95 mmikita95 deleted the chore-components-in-event-payload branch March 4, 2024 12:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants