tests: frontend test framework setup with playwright #268
Conversation
| { type: "metric", locator: `div.CoreMetric.component` }, | ||
| { type: "message", locator: `div.CoreMessage.component` }, | ||
| { type: "videoplayer", locator: `div.CoreVideoPlayer.component` }, | ||
| ]; |
There was a problem hiding this comment.
I have an idea, we should do a pass of the whole templateMap and check whether we have tests for everything mentioned there. If we don't, we fail.
Otherwise we can easily forget.
Or maybe some --strict flag so that we can pass a PR but not release?
Keen to hear your thoughts.
There was a problem hiding this comment.
I was thinking about using templateMap here earlier but I don't have access to this file from here. Thats why I just created list of components base on templateMap.
There was a problem hiding this comment.
If you have access to the core you can use getSupportedComponentTypes without doing an import of templateMap which I agree, wouldn't be the cleanest.
|
I'd really like to start benefiting from this soon, as it gives me more confidence not only when it comes to frontend but also end-to-end. There's the Low Code UI work going on which is big and disruptive, also Fabien's latest PR. Any chance we can merge something in the next few days? |
|
I'm doing what i can to resolve all issues before making it ready to review. |
| console.log( | ||
| `[${ss.pid}] stdout: ${Buffer.from(data, "utf-8").toString()}`, | ||
| ); | ||
| if (data.includes("Builder is available at")) { |
There was a problem hiding this comment.
Any ideas to make this less hacky in the future? Something like a health check, some signal I don't know about?
Probably useful for other purposes too.
|
|
||
| test.setTimeout(5000); | ||
|
|
||
| test.describe('undo and redo', () => { |
There was a problem hiding this comment.
Awesome that you included this
No description provided.