feat: state autocompletion for builder settings fields #383
Conversation
| <script setup lang="ts"> | ||
| import { inject, ref, nextTick } from "vue"; | ||
| import injectionKeys from "../injectionKeys"; | ||
| import Fuse from "fuse.js"; |
There was a problem hiding this comment.
Unpacked size on npm looks very chunky (>400kb). How big is the file actually being loaded?
I'd argue we don't need fuzzy search as it's programming, not an e-commerce product search. But keen to discuss.
There was a problem hiding this comment.
I agree on avoiding library just for fuzzy research. I would recommand to write a utility function to perform fuzzy research if we need it. The algorithme looks simple.
There was a problem hiding this comment.
You shouldn't look at package size this way...
Here you have real size of this package in production build:
But if you insist it could be minified further to something like 23.1kB (7.2 kB gziped)
There was a problem hiding this comment.
Wonder why it didn't use minified version...
There was a problem hiding this comment.
maybe vite is minimizing it by itself? 🤔
| @@ -38,16 +43,16 @@ | |||
| </div> | |||
| </div> | |||
| <div class="formAdd"> | |||
| <input | |||
| <BuilderTemplateInput | |||
There was a problem hiding this comment.
I don't think you can use references to state here, can you please check?
| ref="assistedKeyEl" | ||
| v-model="formAdd.key" | ||
| type="text" | ||
| v-model:value="formAdd.key" |
There was a problem hiding this comment.
To use v-model with BuilderTemplateInput you'll need to use defineModel (at least that's what's documented)
There was a problem hiding this comment.
What I used is described here:
https://vuejs.org/guide/components/v-model#under-the-hood
I needed a little more control of update events
No description provided.