Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom components not loading with cjs extension #406

Conversation

FabienArcellier
Copy link
Collaborator

@FabienArcellier FabienArcellier commented Apr 29, 2024

fix #405


This fix ensure vite build generates js files for custom components

> streamsync-ui@0.0.0 custom.build
> vite build --config vite.config.custom.ts

vite v5.2.8 building for production...
transforming...
✓ 11 modules transformed.
rendering chunks...
computing gzip size...
custom_components_dist/style.css         1.33 kB │ gzip: 0.44 kB
custom_components_dist/templates.umd.js  4.36 kB │ gzip: 1.68 kB
✓ built in 199ms

--- other minor changes

  • the directory src/ui/custom_components_dist is in the ignored files of git
  • the generated directories, ignore from git, are also ignored by eslint

@FabienArcellier FabienArcellier changed the title 54 custom components not loading with cjs extension fix: custom components not loading with cjs extension Apr 29, 2024
@ramedina86 ramedina86 merged commit 6c21a9f into writer:dev Apr 29, 2024
15 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Components not loading with .cjs extension
2 participants