feat: added warning if app already deployed #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raaymax
force-pushed
the
redeploy_warning_2
branch
from
2058fcb
to
b1188a7
Compare
| @@ -15,6 +15,7 @@ | |||
| WRITER_DEPLOY_URL = os.getenv("WRITER_DEPLOY_URL", "https://api.writer.com/v1/deployment/apps") | |||
|
|
|||
| def deploy(path, token, env): | |||
| check_app(token) | |||
There was a problem hiding this comment.
You should add a quiet or force flag for continuous delivery
|
I think the point raised by @FabienArcellier is important. @raaymax I'm guessing it makes more sense to merge this PR and then implement in CLI refactor PR though, right? |
|
agree, with both
for now CI can use |
|
@ramedina86 can we merge this one? |
|
I was just waiting for |
|
Ach a little miss understanding 😅 I will add it to click PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.