-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): introduce CoreColorInput
. WF-9
#486
Conversation
The implementation look promising but I fails to reproduce the video on review environment. |
src/ui/core/index.ts to get component definition based on its type
|
@FabienArcellier & @ramedina86 , I implemented the changes. Here the new screenshot Screencast.from.2024-07-09.22-10-29.webmI have a small doubt regarding predifined colors because:
Let me know what you think about it |
CoreColorInput
+ last colors selected. WF-9CoreColorInput
. WF-9
Thanks It seems good. An improvement for later would be to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, some small changes and I'll merge
Create a new component
CoreColorInput
using a sub-componentBaseInputColor
.The component accept a list of predefined colors using
datalist
(see doc)Screencast.from.2024-07-09.22-10-29.webm