chore(ui): use local fonts instead of CDN. WF-27 #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, looks good, I didn't know about Fontsource. Neat to be able to manage via npm. Can we look into only using local if CDN fails? |
|
I love it. Everything is served through the local server. The cache is used properly on the browser, so I would advocate to keep local diffusion instead of using cdn. (left: dev version, right: version in the PR) (cache usage, the file is only downloaded once) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Fontsource with NPM instead of relying on https://fonts.google.com
Try to spot the difference (I don't see any 🧐 )