Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Bug' in the dice_helper if the skill name contains a & sign #80

Closed
Theik opened this issue Dec 17, 2021 · 1 comment
Closed

'Bug' in the dice_helper if the skill name contains a & sign #80

Theik opened this issue Dec 17, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Theik
Copy link

Theik commented Dec 17, 2021

This is a problem that is likely never going to show up again for anybody, but I'm using the plugin to run it with my Genesys homebrew skillset, and one of the skills has an & sign in it. When the json template is saved, it'll parse this & into an &, which later causes the dice roll helper to fail, as it will try to read a & when it should be reading an &.

It's an extremely minor problem which is unlikely to ever happen again for anybody else, but if you want to enable functionality for & symbols, you can alter line 181 of dice_helper.js by turning it into:

let skill = results['skill'].toLowerCase().replace('&', '&');

The replace there will make it able to find the html entities converted entry, at which point it'll start working again.

@wrycu wrycu added the bug Something isn't working label Dec 17, 2021
@wrycu wrycu self-assigned this Dec 17, 2021
@wrycu
Copy link
Owner

wrycu commented Dec 18, 2021

Fixed in the above commit. Will be released in 0.2.3. Thanks for the report!

@wrycu wrycu closed this as completed Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants