forked from Fintan-contents/mobile-app-crib-notes
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
📝 ToDoアプリ - ToDo一覧画面のFAB(Icon)に設定しているraisedを削除 (#1126)
## ✅ What's done [`rn-spoiler`のExpo SDK 48アップグレード対応](https://github.com/ws-4020/rn-spoiler/pull/133)で以下を検知 ToDo一覧画面のFAB(Icon)は、`react-native-elements`の`Icon`を使用していますが、`raised`を指定した場合に以下のWarningが出力されます。 > WARN (ADVICE) View #355 of type RCTView has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix this, or apply the shadow to a more specific component. `shadow`関連のPropsを扱う場合は`backgroundColor`も設定した方が良いという警告ですが、`raised`を`true`に設定した場合に、`react-native-elements`では`backgroundColor`を設定していないようです。 - https://github.com/react-native-elements/react-native-elements/blob/v3.4.3/src/icons/Icon.tsx#L177 ToDoアプリでは、`Icon`の`raised`の使用を学習の目的としていないので、ToDo一覧画面のFAB(Icon)から`raised`を削除しました。 - [x] `raised`の削除 - 以下で対象を確認(`shadow`系のPropsを使用していないかも併せて確認) - `git grep -E "raised|shadow[Color|Offset|Opacity|Radius]" -- website/` - [x] ToDo一覧画面のキャプチャを貼り付ける箇所のキャプチャ更新
- Loading branch information
1 parent
7877641
commit acff75f
Showing
7 changed files
with
0 additions
and
2 deletions.
There are no files selected for viewing
Binary file modified
BIN
-2.75 KB
(98%)
website/docs/react-native/learn/todo-app/app-hands-on/todo_board.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-143 KB
(14%)
website/docs/react-native/learn/todo-app/app-spec/todo_board_all.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.31 KB
(73%)
...te/docs/react-native/learn/todo-app/app-spec/todo_board_all_indicator_block.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-5.75 KB
(93%)
website/docs/react-native/learn/todo-app/networking/indicator.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.29 KB
(92%)
website/docs/react-native/learn/todo-app/networking/todo_indicator.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters