Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returning the 500 error response when invoking the API after expiring the generated refresh token for the endpoint security #12185

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

YasasRangika
Copy link
Contributor

Purpose

To fix the 500 error response when invoking the API after expiring the generated refresh token for the endpoint security with client credentials grant.

Goal

Fixes: wso2/api-manager#2261

Approach

Change the order of checking the refresh token availability to prevent this behavior with client credentials grant.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1cfcab5) 39.07% compared to head (84f1849) 47.98%.
Report is 9 commits behind head on master.

Files Patch % Lines
...gt/gateway/mediators/oauth/client/OAuthClient.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12185      +/-   ##
============================================
+ Coverage     39.07%   47.98%   +8.90%     
- Complexity        0     4024    +4024     
============================================
  Files          1785     1785              
  Lines        130443   130470      +27     
  Branches      18795    18801       +6     
============================================
+ Hits          50967    62601   +11634     
+ Misses        73003    60624   -12379     
- Partials       6473     7245     +772     
Flag Coverage Δ
integration_tests 42.81% <75.00%> (+11.45%) ⬆️
unit_tests 20.84% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YasasRangika YasasRangika merged commit 1806ea3 into wso2:master Nov 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants