Add DAO layer support to manage the user defined local authenticators #6144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thisara-Welmilla
force-pushed
the
add-cutsom-local-auth-mgt-support-dao-new
branch
from
631d55f to
f1a771d
Compare
Thisara-Welmilla
force-pushed
the
add-cutsom-local-auth-mgt-support-dao-new
branch
from
cf879eb to
50d68e1
Compare
malithie
reviewed
Nov 30, 2024
...ava/org/wso2/carbon/identity/application/common/dao/impl/AuthenticatorManagementDAOImpl.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Nov 30, 2024
| */ | ||
| UserDefinedLocalAuthenticatorConfig addUserDefinedLocalAuthenticator( | ||
| UserDefinedLocalAuthenticatorConfig authenticatorConfig, int tenantId, AuthenticationType type) | ||
| throws AuthenticatorMgtException; |
There was a problem hiding this comment.
I'm actually thinking at the DAO layer we should ideally have an exception type that is different from the service layer which incorporates error codes and messages. However this seems to be the practice we are following. So it's fine to proceed, but some are we need to think through
malithie
reviewed
Nov 30, 2024
...rc/main/java/org/wso2/carbon/identity/application/common/dao/AuthenticatorManagementDAO.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Nov 30, 2024
...ava/org/wso2/carbon/identity/application/common/dao/impl/AuthenticatorManagementDAOImpl.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Nov 30, 2024
...ava/org/wso2/carbon/identity/application/common/dao/impl/AuthenticatorManagementDAOImpl.java
Show resolved
Hide resolved
malithie
reviewed
Nov 30, 2024
...ava/org/wso2/carbon/identity/application/common/dao/impl/CacheBackedAuthenticatorMgtDAO.java
Outdated
Show resolved
Hide resolved
Thisara-Welmilla
force-pushed
the
add-cutsom-local-auth-mgt-support-dao-new
branch
2 times, most recently
from
3083659 to
02c6b59
Compare
Thisara-Welmilla
force-pushed
the
add-cutsom-local-auth-mgt-support-dao-new
branch
from
02c6b59 to
812538e
Compare
Thisara-Welmilla
force-pushed
the
add-cutsom-local-auth-mgt-support-dao-new
branch
from
d6dd220 to
d8a8ca1
Compare
|
malithie
reviewed
Dec 2, 2024
| } | ||
|
|
||
| private int getAuthenticatorIdentifier(Connection dbConnection, String authenticatorConfigName, | ||
| int tenantId) throws AuthenticatorMgtServerException, SQLException { |
There was a problem hiding this comment.
Why do you build and throw this AuthenticatorMgtServer Exception here ?
IMO, this should just return the SQL Exception and should have been handled at the same transaction
|
Reopen with #6172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task issue:
With this PR following changes may introduced the dao layer to manage the user defined local authenticator and its related class.
Related PRs:
Add service layer support to manage the user defined local authenticators #6071
Add unit tests for supporting manage the user defined local authenticators #6072
New API /authenticators/custom to manage user defined local authenticators identity-api-server#736