Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2.0] Add Git release tag as a label & enable SSL cert verification for wget #361

Merged

Conversation

ThilinaManamgoda
Copy link
Contributor

Purpose

This PR introduces the Docker source Git release tag as a label and enable SSL verification for wget. This fixes #360, #357, #356

Goals

Introduce the Docker source Git release tag as a label.
Enable SSL verification for wget.

Approach

Use the dockerfile instruction LABEL to add Git release tag as a label.
Removes existing option --no-check-certificate for wget and update the CA certificates for Ubuntu 16.04 by installing ca-certificates package.

Test environment

Client: Docker Engine - Community
Version: 19.03.12
API version: 1.40
Go version: go1.13.10
Git commit: 48a66213fe
Built: Mon Jun 22 15:45:36 2020
OS/Arch: linux/amd64
Experimental: false

Server: Docker Engine - Community
Engine:
Version: 19.03.12
API version: 1.40 (minimum version 1.12)
Go version: go1.13.10
Git commit: 48a66213fe
Built: Mon Jun 22 15:44:07 2020
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: 1.2.13
GitCommit: 7ad184331fa3e55e52b890ea95e65ba581ae3429
runc:
Version: 1.0.0-rc10
GitCommit: dc9208a3303feef5b3839f4323d9beb36df0a9dd
docker-init:
Version: 0.18.0
GitCommit: fec3683

@chirangaalwis chirangaalwis merged commit 0eb9da0 into wso2:2.2.x Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants