[5.9] Modified Dockerfiles to have OS based base image and adoptium JDK 8 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gershom96
changed the title
RidmiR
reviewed
Mar 9, 2022
dockerfiles/alpine/is/Dockerfile
Outdated
| ARG WSO2_SERVER=${WSO2_SERVER_NAME}-${WSO2_SERVER_VERSION} | ||
| ARG WSO2_SERVER_HOME=${USER_HOME}/${WSO2_SERVER} | ||
| ARG WSO2_SERVER_DIST_URL=https://bintray.com/wso2/binaryGA/download_file?file_path=${WSO2_SERVER}.zip | ||
| ARG WSO2_SERVER_DIST_URL=https://github.com/wso2/${WSO2_SERVER_REPOSITORY}/releases/download/v${WSO2_SERVER_VERSION}/${WSO2_SERVER}.zip |
There was a problem hiding this comment.
we don't have 5.9 zip artifacts in the given location. This link is not downloadable.
https://github.com/wso2/product-is/releases/tag/v5.9.0
RidmiR
reviewed
Mar 9, 2022
dockerfiles/alpine/is/Dockerfile
Outdated
| # build arguments for external artifacts | ||
| ARG DNS_JAVA_VERSION=2.1.8 | ||
| ARG K8S_MEMBERSHIP_SCHEME_VERSION=1.0.5 | ||
| ARG K8S_MEMBERSHIP_SCHEME_VERSION=1.0.8 |
There was a problem hiding this comment.
Any reason for this K8 scheme version bump?
RidmiR
reviewed
Mar 9, 2022
dockerfiles/ubuntu/is/Dockerfile
Outdated
| @@ -1,6 +1,6 @@ | |||
| # ------------------------------------------------------------------------ | |||
| # | |||
| # Copyright 2017 WSO2, Inc. (http://wso2.com) | |||
| # Copyright 2021 WSO2, Inc. (http://wso2.com) | |||
There was a problem hiding this comment.
We don't needs to change the year
RidmiR
reviewed
Mar 9, 2022
dockerfiles/ubuntu/is/Dockerfile
Outdated
| ARG WSO2_SERVER=${WSO2_SERVER_NAME}-${WSO2_SERVER_VERSION} | ||
| ARG WSO2_SERVER_HOME=${USER_HOME}/${WSO2_SERVER} | ||
| ARG WSO2_SERVER_DIST_URL=https://bintray.com/wso2/binaryGA/download_file?file_path=${WSO2_SERVER}.zip | ||
| ARG WSO2_SERVER_DIST_URL=https://github.com/wso2/${WSO2_SERVER_REPOSITORY}/releases/download/v${WSO2_SERVER_VERSION}/${WSO2_SERVER}.zip |
dockerfiles/alpine/is/Dockerfile
Outdated
| @@ -1,6 +1,6 @@ | |||
| # ------------------------------------------------------------------------ | |||
| # | |||
| # Copyright 2018 WSO2, Inc. (http://wso2.com) | |||
| # Copyright 2021 WSO2, Inc. (http://wso2.com) | |||
There was a problem hiding this comment.
No need to update the year. If it is a new file, then we need to add the licence header
dockerfiles/ubuntu/is/Dockerfile
Outdated
|
|
||
| ENV LANG='en_US.UTF-8' LANGUAGE='en_US:en' LC_ALL='en_US.UTF-8' | ||
|
|
||
| #Install JDK Dependencies |
There was a problem hiding this comment.
Lets add a space after #. Also end the comment with a full stop. Look at the other places as well.
gershom96
force-pushed
the
5.9.x-dockerfiles
branch
from
12bb345 to
0d15212
Compare
gershom96
force-pushed
the
5.9.x-dockerfiles
branch
from
0d15212 to
5644628
Compare
RidmiR
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changed the dockerfiles to have a base OS image with JDK installed on top of it, instead of directly importing a jdk installed image. Furthermore, brought the dockerfiles to a common format according to what was done in #316 and #318.
Security checks
Related PRs
#318
#316