Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Action Management API for consistency with docs. #777

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Update Action Management API for consistency with docs. #777

merged 1 commit into from
Jan 17, 2025

Conversation

malithie
Copy link
Member

Purpose

Resolves wso2/product-is#22271

@malithie malithie requested a review from ashanthamara January 16, 2025 19:43
ashanthamara
ashanthamara previously approved these changes Jan 16, 2025
View reviewed changes
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12816632617

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12816632617
Status: failure

@malithie
Copy link
Member Author

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/12816632617 Status: failure

Following test failures are noted.
RegistryMountTestCase.testClear:138->deleteApplication:307 Application deletion failed expected:<204> but was:<401> [ERROR] RegistryMountTestCase.testInit:129->createApplication:301 Error while creatin...

These tests runs along with action management api and action execution related test cases. Also these tests cases has been failing intermittently for a while now and not related to this fix.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12824716449

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12824716449
Status: failure

@malithie
Copy link
Member Author

malithie commented Jan 17, 2025 •
edited
Loading

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/12824716449 Status: failure

The failure is due to below
RegistryMountTestCase.testClear:138->deleteApplication:307 Application deletion failed expected:<204> but was:<401> [ERROR] RegistryMountTestCase.testInit:129->createApplication:301 Error while creatin...

This test runs along with action management api and action execution related test cases. Also these tests case has been failing intermittently for a while now and not related to this fix.

Thus merging this PR as the overall test result is successful

@malithie malithie merged commit c0dffd7 into wso2:master Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thisara-Welmilla Thisara-Welmilla Thisara-Welmilla approved these changes

@ashanthamara ashanthamara ashanthamara left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have a consistent yaml file for action management in API implementation and docs
4 participants
@malithie @jenkins-is-staging @ashanthamara @Thisara-Welmilla