Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🧹 UNIFICATION CLEANUP] Refactor duplicate enums and constants #6701

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

brionmario
Copy link
Member

Purpose

Refactor UserAccountTypes, AdminAccountTypes etc.

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@brionmario
Copy link
Member Author

brionmario commented Aug 2, 2024

Since this is a refactoring PR.
I'm not going to upgrade to useRequiredScopes.

/home/runner/work/identity-apps/identity-apps/features/admin.administrators.v1/components/all-users-list.tsx
Error:   32:36  error  'hasRequiredScopes' import from '@wso2is/core/helpers' is restricted. Please use "import { useRequiredScopes } from '@wso2is/access-control'" instead. Refer documentation: https://github.com/wso2/identity-apps/blob/master/docs/write-code/PERFORMANCE.md#use-userequiredscopes-hook-instead-of-hasrequiredscopes-function  no-restricted-imports

/home/runner/work/identity-apps/identity-apps/features/admin.administrators.v1/components/guests/edit-guest-user.tsx
Error:   [30](https://github.com/wso2/identity-apps/actions/runs/10197835175/job/28211507732?pr=6701#step:9:31):10  error  'hasRequiredScopes' import from '@wso2is/core/helpers' is restricted. Please use "import { useRequiredScopes } from '@wso2is/access-control'" instead. Refer documentation: https://github.com/wso2/identity-apps/blob/master/docs/write-code/PERFORMANCE.md#use-userequiredscopes-hook-instead-of-hasrequiredscopes-function  no-restricted-imports

/home/runner/work/identity-apps/identity-apps/features/admin.administrators.v1/components/guests/onboarded-guest-user-list.tsx
Error:   47:36  error  'hasRequiredScopes' import from '@wso2is/core/helpers' is restricted. Please use "import { useRequiredScopes } from '@wso2is/access-control'" instead. Refer documentation: https://github.com/wso2/identity-apps/blob/master/docs/write-code/PERFORMANCE.md#use-userequiredscopes-hook-instead-of-hasrequiredscopes-function  no-restricted-imports

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit e56db66 into wso2:master Aug 2, 2024
5 of 6 checks passed
@brionmario brionmario changed the title Refactor duplicate enums and constants [🧹 UNIFICATION CLEANUP] Refactor duplicate enums and constants Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants