[🧹 UNIFICATION CLEANUP] Refactor extensions/components directory
#6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brionmario
changed the title
brionmario
force-pushed
the
code-cleanup-2024-extensions
branch
from
bd23e5d to
2bccd03
Compare
brionmario
force-pushed
the
code-cleanup-2024-extensions
branch
from
cb3df77 to
7fe5d52
Compare
brionmario
changed the title
extensions/components directory
Comment on lines
+51
to
+62
| const { data, error, isValidating, mutate } = useRequest<Data, Error>( | ||
| requestConfig | ||
| ); | ||
|
|
||
| return { | ||
| data, | ||
| error, | ||
| isLoading: !data && !error, | ||
| isValidating, | ||
| mutate | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Moving forward we can directly use isLoading property from swr hook. Please check other places as well
Suggested change
| const { data, error, isValidating, mutate } = useRequest<Data, Error>( | |
| requestConfig | |
| ); | |
| return { | |
| data, | |
| error, | |
| isLoading: !data && !error, | |
| isValidating, | |
| mutate | |
| }; | |
| }; | |
| const { data, error, isLoading, isValidating, mutate } = useRequest<Data, Error>( | |
| requestConfig | |
| ); | |
| return { | |
| data, | |
| error, | |
| isLoading, | |
| isValidating, | |
| mutate | |
| }; | |
| }; |
There was a problem hiding this comment.
+1
However, since this PR only focuses on refactoring the existing files and logic, lets not do any drastic logic changes to avoid regressions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6882 +/- ##
=======================================
Coverage 31.79% 31.79%
=======================================
Files 41 41
Lines 890 890
Branches 204 220 +16
=======================================
Hits 283 283
+ Misses 607 557 -50
- Partials 0 50 +50
Flags with carried forward coverage won't be shown. Click here to find out more. |
brionmario
force-pushed
the
code-cleanup-2024-extensions
branch
from
e89f164 to
8900f53
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
pavinduLakshan
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Completely refactor the
admin.extensions.v1/componentsdirectly and move the logic to related features.Related Issues
Related PRs
Checklist
Security checks