Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 [WIP][NEW SIGNUP] Improve functionality #7229

Open
wants to merge 35 commits into
base: new-signup
Choose a base branch
from

Conversation

brionmario
Copy link
Member

Purpose

This pull request includes several changes to the features/admin.flow-builder-core.v1 module, focusing on code refactoring, adding new components, and updating existing ones. The most important changes include adding new hooks and components, modifying existing components for better functionality, and updating styles for a consistent user interface.

New Hooks and Components:

  • Added useGetFlowBuilderCoreActions hook to fetch actions supported by the flow builder (features/admin.flow-builder-core.v1/api/use-get-flow-builder-core-actions.ts).
  • Introduced OTPInputAdapter component for handling OTP inputs (features/admin.flow-builder-core.v1/components/elements/components/adapters/input/otp-input-adapter.tsx).

Component Modifications:

  • Updated DecoratedVisualFlow component to extend VisualFlowPropsInterface and removed redundant HTMLAttributes (features/admin.flow-builder-core.v1/components/decorated-visual-flow.tsx).
  • Modified CommonComponentPropertyFactory and CommonWidgetPropertyFactory to remove previousValue parameter from the onChange method (features/admin.flow-builder-core.v1/components/element-property-panel/common-component-property-factory.tsx, features/admin.flow-builder-core.v1/components/element-property-panel/common-widget-property-factory.tsx). [1] [2]
  • Refactored ElementProperties component to use merge and set for updating properties and variants (features/admin.flow-builder-core.v1/components/element-property-panel/element-properties.tsx). [1] [2] [3] [4]

Style Updates:

  • Added styles for ButtonAdapter component to ensure consistent appearance (features/admin.flow-builder-core.v1/components/elements/components/adapters/button-adapter.scss).
  • Updated ButtonAdapter component to include fullWidth property and handle social button styling (features/admin.flow-builder-core.v1/components/elements/components/adapters/button-adapter.tsx). [1] [2]

Minor Enhancements:

  • Added InputLabelProps to DefaultInputAdapter and PhoneNumberInputAdapter to handle required labels (features/admin.flow-builder-core.v1/components/elements/components/adapters/input/default-input-adapter.tsx, features/admin.flow-builder-core.v1/components/elements/components/adapters/input/phone-number-input-adapter.tsx). [1] [2]

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (1b2bc7e) to head (d8b6445).
Report is 7 commits behind head on new-signup.

Additional details and impacted files
@@             Coverage Diff             @@
##           new-signup    #7229   +/-   ##
===========================================
  Coverage       32.02%   32.02%           
===========================================
  Files              41       41           
  Lines             893      893           
  Branches          220      204   -16     
===========================================
  Hits              286      286           
- Misses            557      607   +50     
+ Partials           50        0   -50     
Flag Coverage Δ
@wso2is/core 32.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants