Add Trigger Error mediator #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Trigger Error mediator <triggererror type="string" (errorMessage="string" | expression="expression")/>
GDLMadushanka
force-pushed
the
triggerError
branch
from
3521103 to
bf80787
Compare
| * Creates a trigger error mediator through the supplied XML configuration | ||
| * <p/> | ||
| * <pre> | ||
| * <triggererror type="string" (errorMessage="string" | expression="expression")/> |
There was a problem hiding this comment.
Instead of having two attributes for literal and expression, is it possible to have a Value ?
There was a problem hiding this comment.
you mean the following syntax
<throwError type="string">(value | expression)</ throwError>
or
<throwError type="string" errorMessage="value" />
There was a problem hiding this comment.
<throwError type="string" errorMessage="value" /> looks better
| private static final QName ATT_ERROR_MSG = new QName("errorMessage"); | ||
| private static final QName ATT_TYPE = new QName("type"); | ||
| private static final QName TRIGGER_ERROR_Q | ||
| = new QName(XMLConfigConstants.SYNAPSE_NAMESPACE, "triggererror"); |
There was a problem hiding this comment.
trigger-error is more readable. WDYT?
There was a problem hiding this comment.
throw-error is much better IMO
There was a problem hiding this comment.
We have the following naming convention in mediators
<datamapper config="name" inputSchema="string" inputType="string" outputSchema="string" outputType="string"/>
<jsontransform [schema="string"]>
<dataServiceCall serviceName="data-service-name">
Address review comments
SanojPunchihewa
approved these changes
Dec 17, 2024
|
related to wso2/product-micro-integrator#3843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose