update config to modify rules #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lra-wtag
approved these changes
Jun 16, 2022
|
Generally, it looks good to me. Could you explain in the PR description a bit more why these are legit changes? Something like a sales pitch? Then we know later why we changed it (except "just annoying")... |
@rah-wtag please create a story and link this pr as suggested by Raffael |
luxflux
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the config rules for reek.
We are changing the rules for duplicate Method calls, because we end up always ignoring this lint as most of the time it is not necessary / inconvenient. We did not disable it we allowed the max calls to 4.
We are also changing the repeated conditional rule and allowing it to do 4 max ifs. This too is most of the time ignored by devs and most of the time it does not make sense to fix the lint in complex services.