Exclude contents of subdirectories of the standard submodule #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I spotted that this file was included, but then forgot to do anything about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24.
This is perhaps not the most elegant fix, but it appears to be effective, correctly excluding
nifti_mrs/standard/explanatory_doc/conf.pyfrom the sdist and therefore also from the wheels, as test-built withpython3 -m build.Note that setuptools is recalcitrant (pypa/setuptools#3260) about this sort of thing.
(If the sdist does contain
nifti_mrs/standard/explanatory_doc/conf.py, as when this PR is applied as a patch to the existing 1.2.0 sdist, then this PR doesn’t keep the wheel from containing it too.)