Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets file for API Keys #692

Closed
wants to merge 1 commit into from

Conversation

alexfornuto
Copy link
Contributor

@alexfornuto alexfornuto commented Oct 11, 2019

This is still very much a work in progress. I'm attempting to help resolve #517 by creating a single file to store API keys (as discussed here), which can then be excluded from config backup and management systems like RCM and the like.

A solution like this seems better to me than loading these keys as environment variables in the shell, where they could be read in memory by other programs.

I've made the default file and added it to the config, and now my build tests return:

app/wtf_app.go:144:5: secrets declared and not used

This is where my limited knowledge of Go ends. What I do not yet know how to do is take the contents of the secrets file and load them as environment variables. Anyone who wants to contribute to this branch is welcome to do so. Likewise, any documentation of tutorials you think would be useful in finishing this would be much appreciated.

#hacktoberfest

@@ -31,6 +31,7 @@ require (
github.com/gogo/protobuf v1.3.0 // indirect
github.com/golang/glog v0.0.0-20170312005925-543a34c32e4d // indirect
github.com/golang/groupcache v0.0.0-20191002201903-404acd9df4cc // indirect
github.com/google/btree v1.0.0 // indirect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this change happened.

@noxer
Copy link
Contributor

noxer commented Oct 11, 2019

Go doesn't allow you to declare variables and then not use them. That is why you are getting the error.

@alexfornuto
Copy link
Contributor Author

Go doesn't allow you to declare variables and then not use them. That is why you are getting the error.

Yes, I understand that. What I don't know is where/how to use them.

In other words, it's not used because I don't know how to turn YAML into variables, nor where I should be doing that.

@senorprogrammer
Copy link
Collaborator

Closing this out due to inactivity. Feel free to reopen if anything changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Security: open call for thoughts on securing WTF's config file
3 participants