Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Conda-related images #70

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Remove Conda-related images #70

merged 1 commit into from
Sep 26, 2023

Conversation

kjsanger
Copy link
Member

No description provided.

@kjsanger kjsanger requested review from dkj and jmtcsngr September 25, 2023 14:32
dkj
dkj approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@dkj dkj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe within this repo - but we should be labelling npg_conda as deprecated (README) and disabling all its builds before merging this, no?

@kjsanger
Copy link
Member Author

Looks safe within this repo - but we should be labelling npg_conda as deprecated (README) and disabling all its builds before merging this, no?

That should be done, yes. It isn't dependent on this; the existing images won't disappear.

@kjsanger kjsanger merged commit b52a274 into wtsi-npg:devel Sep 26, 2023
@kjsanger kjsanger deleted the remove-conda branch September 26, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkj dkj dkj approved these changes

@jmtcsngr jmtcsngr Awaiting requested review from jmtcsngr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjsanger @dkj