Fix local builds broken by adding --pull globally #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding --pull to all builds breaks local builds because Docker expects the pulled image to be in a registry. This change is a compromise which uses --pull only for third party images which are always obtained from a registry and avoids it for images built locally by the Makefile.
kjsanger
force-pushed
the
bugfix/only-pull-base-images
branch
from
a9d956d to
b9d0f0f
Compare
kjsanger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding --pull to all builds breaks local builds because Docker expects the pulled image to be in a registry.
This change is a compromise which uses --pull only for third party images which are always obtained from a registry and avoids it for images built locally by the Makefile.