Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle irods clients #92

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Conversation

mksanger
Copy link
Contributor

Add action to bundle irods clients (iinit, ils, imeta, baton-*) with exodus and add them to the release.

@mksanger mksanger requested a review from kjsanger January 17, 2024 10:05
Copy link
Member

@kjsanger kjsanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on where to put the environment setup script with LD_PRELOAD that we'll need to install at some point?

.github/workflows/create-release.yml Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Show resolved Hide resolved
.github/workflows/create-release.yml Outdated Show resolved Hide resolved
@mksanger
Copy link
Contributor Author

What are your thoughts on where to put the environment setup script with LD_PRELOAD that we'll need to install at some point?

I'm making the ansible make the script when it unpacks the bundle, since it can be built from a template, once the bundle is unpacked, and we can find the path to the libraries.

Make bundle name more descriptive

Add some documentation for how the bundle is used
@mksanger
Copy link
Contributor Author

I noticed that the environment variables were not making it through the workflow, so I've been trying to sort that out, prerelease is still broken

@kjsanger kjsanger merged commit b6b3664 into wtsi-npg:devel Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants