Scripts graph view #283
Scripts graph view #283
Conversation
…m/Cognifide/APM into scripts-graph-view
…om/Cognifide/APM into scripts-graph-view � Conflicts: � app/aem/core/src/main/kotlin/com/cognifide/apm/core/endpoints/ScriptsGraphServlet.kt
…s-graph-view � Conflicts: � settings.gradle.kts
…om/Cognifide/APM into scripts-graph-view
| @@ -0,0 +1,30 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
You should change name of the file, and also provide file with script, because it's missing.
There was a problem hiding this comment.
Yeah, it's been pushed by accident tbh. I was just checking how the graph looks like with more scripts and accidentally added to git apparently
app/aem/ui.react/clientlib.config.js
Outdated
| context: BUILD_DIR, | ||
| clientLibRoot: CLIENTLIB_DIR, | ||
| libs: { | ||
| name: 'clientlib-react', |
There was a problem hiding this comment.
I think that this name is misleading. Of course this clientlib uses react, but it main purpose is to provide graph view of scripts. So it should be named 'graphView' or something similar.
app/aem/ui.react/clientlib.config.js
Outdated
| libs: { | ||
| name: 'clientlib-react', | ||
| allowProxy: true, | ||
| categories: ['apm.react'], |
There was a problem hiding this comment.
Category also should be changed to more meaningful.
app/aem/ui.react/assembly.xml
Outdated
| @@ -0,0 +1,16 @@ | |||
| <assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd"> | |||
settings.gradle.kts
Outdated
| @@ -6,6 +6,7 @@ include(":app:aem:actions.checks") | |||
| include(":app:aem:actions.main") | |||
| include(":app:aem:ui.apps") | |||
| include(":app:aem:ui.content") | |||
| include(":app:aem:ui.react") | |||
There was a problem hiding this comment.
You should rename this module to ui.frontend as it is named in adobe's archetype.
…to scripts-graph-view � Conflicts: � build.gradle.kts
No description provided.