adds files always directly under /conf/apm/scripts bug #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 10, 2021
…s files directly under /conf/apm/scripts
devzbysiu
reviewed
Mar 11, 2021
| @@ -60,7 +60,7 @@ class ScriptUploadServlet : AbstractFormServlet<ScriptUploadForm>(ScriptUploadFo | |||
|
|
|||
| override fun doPost(form: ScriptUploadForm, resourceResolver: ResourceResolver): ResponseEntity<Any> { | |||
| return try { | |||
| val script = scriptStorage.save(form.fileName, form.file, form.toLaunchMetadata(), form.overwrite, resourceResolver) | |||
| val script = scriptStorage.save(form.savePath, form.fileName, form.file, form.toLaunchMetadata(), form.overwrite, resourceResolver) | |||
There was a problem hiding this comment.
If you are already changing the interface here, I would try to minimize the number of arguments. 6 arguments in a method call are too much. In this case, you can pass the whole form as 5 out of 6 arguments comes from the form. However, this method comes from the interface so it may not be that easy to change it. If this method is used in different contexts where form is not available, you can try to use other techniques described here: https://refactoring.guru/pl/smells/long-parameter-list
devzbysiu
approved these changes
Mar 11, 2021
dprzybyl
deleted the
bugfix/adds-files-always-directly-under-conf-apm-scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.