No exact execution start timestamp and duration #436 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,12 +77,16 @@ protected void doGet(SlingHttpServletRequest request, SlingHttpServletResponse r | |||
| return ResponseEntity.ok("Script successfully executed") | |||
| .addEntry("status", status.getStatus()) | |||
| .addEntry("output", ((ExecutionStatus.FinishedSuccessfulExecution) status).getEntries()) | |||
| .addEntry("path", ((ExecutionStatus.FinishedSuccessfulExecution) status).getPath()); | |||
| .addEntry("path", ((ExecutionStatus.FinishedSuccessfulExecution) status).getPath()) | |||
There was a problem hiding this comment.
why these casts are neeed here?
There was a problem hiding this comment.
why/ how about using direct type here? if cast is used then abstraction should be dropped
| public Calendar getStartTime() { | ||
| return startTime; | ||
| } | ||
|
|
||
| @Override | ||
| public long determineExecutionDuration() { |
There was a problem hiding this comment.
opt-in / if you could use more dedicated types like https://docs.oracle.com/javase/8/docs/api/java/time/Duration.html
| List<ExecutionResult.Entry> entries = executionSummary.getResult().getEntries(); | ||
| ExecutionResult.Entry errorEntry = executionSummary.getResult().getLastError(); | ||
| if (errorEntry != null) { | ||
| return new ExecutionStatus.FinishedFailedExecution(path, entries, errorEntry); | ||
| return new ExecutionStatus.FinishedFailedExecution(path, timestamp, formattedDate, entries, errorEntry); |
There was a problem hiding this comment.
ExecutionXX.YyYYExecution
DRY rule violated
| formattedDate = determineFormattedDate(date); | ||
| } | ||
|
|
||
| public static String determineFormattedDate(Calendar date) { |
There was a problem hiding this comment.
how about just format() / KISS rule ;)
fully qualified it will be DateFormatter.format instead of DateFormatter.determineFormattedDate
krystian-panek-vmltech
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.