CQUT-17 'cqosgi' has lost last bundle when used without -m parameter

[rakk]

'cqosgi' is losing last bundle when used without -m parameter

[kitarek]

Hi rakk,

thanks for submitting your bug. Actually I've checked the original JSON and the list of bundles provided in pretty printed and machine format and it's correct.

However the number of reported bundles by tool is incorrect and the line ending for -m mode is missing at the end of output stream, which I can confirm.

The explanation (TL;DR)

Please keep in mind correct facts for my CQ instance:

• My OSGI console gives the total number of bundles set to 325.
• nl is command which prints line numbers as prefixes for original ones
• head, tail commands shows given number of lines from the beginning or end of stream
• wc -l gives number of lines ended correctly by new line character

Please see the outputs below and my explanation:

• cqosgi is reporting incorrectly only 324 bundles instead of 325. Please also note that I'm using line numbering and showing 3 lines which 2 are numbered as output header:

$ ./cqosgi -u admin | nl | head -n 3
1   324 bundles

2   ID   SYMBOL                                                                 STATUS     VERSION                        NAME

• The total number of lines is 327 but decreasing number lines counted as header (2) it gives 325 bundles.

 $ ./cqosgi -u admin | nl | tail -n 1
 327        334  com.my.favourite.advanced.osgi.bundle                                   Active     X.Y.Z             My fantastic bundle

• Actually for machine output the list of bundles contains 325 items:

$ ./cqosgi -m -u admin | nl | tail -n 1
325 334 om.my.favourite.advanced.osgi.bundle                                   Active     X.Y.Z             My fantastic bundle

$ ./cqosgi -m -u admin | nl | head -n 1
 1  0   org.apache.felix.framework  Active  3.0.8.B006  System Bundle

Summary - What is wrong and what should be fixed

• wc command shows only 324 bundles because there is missing line ending for the last line:

  ./cqosgi -m -u admin | wc -l 
  324
  

• the tool incorrectly displays only 324 bundles in the header

[kitarek]

Could you please confirm whether you see the same behavior ?

Thanks once again for submitting the bug.
Arek

[kitarek]

Please have a look at the branch: https://github.com/Cognifide/CQ-Unix-Toolkit/tree/CQUT-17
Please confirm if this fixes your problem so I will release 1.1.2

[kitarek]

No response so I'm assuming that CQUT-17 branch fixes your problem.
The fix is released in scope of CQ Unix Toolkit 1.1.2.

Arek