-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable proxy handling for native fetch and connectrpc calls #1124
Merged
AndreasZeissner
merged 11 commits into
main
from
andi/eng-5607-implement-support-for-https-proxy-in-wgc
Aug 28, 2024
Merged
feat: enable proxy handling for native fetch and connectrpc calls #1124
AndreasZeissner
merged 11 commits into
main
from
andi/eng-5607-implement-support-for-https-proxy-in-wgc
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the proxy relies on undici for now undici does not respect the HTTP_PROXY vars, it's planned to build it in from v23 on by default: nodejs/node#43187 (comment) > My current plan is to add support for the HTTP_PROXY env variable behind a flag in v22 (and possibly v20), then unflag in v23. Using global dispatcher is the current way to go for native fetch, therefore undici needs to be added. For connectrpc the agent will be passed down the chain: /** * Options passed to the request() call of the Node.js built-in * http or https module. * example proxy trace: 22:05:23 HTTPS POST localhost/auth/realms/cosmo/protocol/openid-connect/token 200 application/json 2.0k 202ms 22:05:35 HTTP POST localhost/wg.cosmo.platform.v1.PlatformService/DeleteFederatedGraph 200 application/proto 44b 64ms
Aenimus
reviewed
Aug 28, 2024
Aenimus
reviewed
Aug 28, 2024
Aenimus
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Setting the proxy relies on undici for now undici does not respect the HTTP(S)_PROXY vars, it's planned to build it in from v23 on by default:
nodejs/node#43187 (comment)
Using global dispatcher is the current way to go for native fetch,
therefore undici needs to be added.
For connectrpc the agent will be passed down the chain:
Depending on the proxy, setting:
export NODE_TLS_REJECT_UNAUTHORIZED=0
might be needed (e.g. calling the wgc npm "update" command)TODO