feat: forward generated request id to subgraph in router #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to tell me where to add tests or anything ! |
StarpTech
requested changes
Feb 15, 2024
oxyno-zeta
changed the title
oxyno-zeta
force-pushed
the
add-request-id
branch
from
d72c2e3
to
c5f7334
Compare
…to subgraph Related to issue wundergraph#534
oxyno-zeta
force-pushed
the
add-request-id
branch
from
1a365f0
to
10d53ff
Compare
|
The tests indicate a race in the implementation. I'll take a look. #458 seems related. |
|
Hi @oxyno-zeta, I'm closing this PR in favor of #573 I had to modify a few places. |
|
Hello @StarpTech , sure no problem! Thanks for taking this time ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generated request id into request to allow forward to subgraph
Related to issue #534
Motivation and Context
That will allow to forward generated request id to subgraphs
TODO