Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add configurable schema linting #596

Merged
merged 28 commits into from
Mar 11, 2024
Merged

feat: add configurable schema linting #596

merged 28 commits into from
Mar 11, 2024

Conversation

JivusAyrus
Copy link
Member

@JivusAyrus JivusAyrus commented Mar 2, 2024 •
edited
Loading

Adds schema linting feature. Performs lint on every check command.
Lets users to configure their linter rules.

TODO

Lint.Check.mp4

StarpTech
StarpTech requested changes Mar 8, 2024
View reviewed changes
controlplane/src/core/composition/schemaLint.ts Outdated Show resolved Hide resolved
controlplane/test/lint.test.ts Show resolved Hide resolved
studio/src/components/checks/lint-issues-table.tsx Show resolved Hide resolved
studio/src/pages/[organizationSlug]/lint-policy.tsx Outdated Show resolved Hide resolved
studio/src/pages/[organizationSlug]/lint-policy.tsx Outdated Show resolved Hide resolved
studio/src/pages/[organizationSlug]/lint-policy.tsx Outdated Show resolved Hide resolved
StarpTech
StarpTech approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@JivusAyrus JivusAyrus merged commit c662485 into main Mar 11, 2024
16 checks passed
PeteMac88 pushed a commit to gastromatic/cosmo that referenced this pull request Mar 11, 2024
@JivusAyrus @PeteMac88
feat: add configurable schema linting (wundergraph#596)
efbab0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

@thisisnithin thisisnithin Awaiting requested review from thisisnithin

Assignees
No one assigned
Labels
cli connect controlplane monorepo protocol studio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JivusAyrus @StarpTech