Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job 404 should not throw an exception #666

Closed
tadast opened this issue Jul 19, 2023 · 0 comments
Closed

Job 404 should not throw an exception #666

tadast opened this issue Jul 19, 2023 · 0 comments

Comments

@tadast
Copy link
Collaborator

tadast commented Jul 19, 2023

When a job is not found i.e. when visiting <sequenceserver-hostname>/this-job-definitelly-does-not-exist an exception is thrown. This results in exception notifications for those hosting sequenceserver instances. 404 not found is not an exceptional case, so perhaps it should be handled at the action level with a halt 404 and optionally rendering a dedicated 404 page.

image
gorsyan added a commit to gorsyan/sequenceserver that referenced this issue Dec 6, 2023
@gorsyan
Issue wurmlab#666 Work in progress
2ebd98e 
422 exception handling
@gorsyan gorsyan mentioned this issue Dec 6, 2023
Closed
gorsyan added a commit to gorsyan/sequenceserver that referenced this issue Dec 7, 2023
@gorsyan
Issue wurmlab#666 Work in progress
e5d9e7d 
422 exception handling
yannickwurm pushed a commit that referenced this issue Dec 21, 2023
@gorsyan
Fixed the job 404 exception error #666 (#710)
22aa5e9 
* Fix Exception Handling and Implement Error Page
* Fixed the issues that arose from Code Climate
* Last Fix of routes.rb issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yannickwurm @tadast