Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record makeblastdb errors for debugging purposes #683

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

tadast
Copy link
Collaborator

@tadast tadast commented Sep 28, 2023

Formatting databases seems to be happening in a forked process, so printing the stderr does not have the desired effect to aid the debugging. The shell out utility already has a way to store stderr as a separate file, so save it next to the database or the database directory that is being formatted when the error occurrs.

@ghost
Copy link

ghost commented Sep 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

formatting databases seems to be happening in a forked process,
so printing the stderr does not seem to have the desired effect
to aid the debugging. The shellou utility already has a way to
store stderr as a separate file, so save it next to the dababase or
database directory that was being formatted when the error occured.
@yannickwurm yannickwurm merged commit a9a128b into wurmlab:master Sep 29, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants