Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating readme #35

Merged
merged 1 commit into from
Mar 27, 2023
Merged

updating readme #35

merged 1 commit into from
Mar 27, 2023

Conversation

chrisamiller
Copy link
Member

No description provided.

@chrisamiller chrisamiller merged commit c175dd3 into wustl-oncology:main Mar 27, 2023
Copy link
Member

@tmooney tmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. As much as I would prefer to use WUSTL everywhere, made a few suggestions based on the MarComm style guide.

[manual-workflows/README.md](manual-workflows/README.md)
- Running the Immunogenomics workflow (immuno.wdl) manually and
assuming the your input data is on a local machine that is not
associated with WASHU in any way. For example, an external institution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide says to use WashU with only the W and U capitalized: https://marcomm.wustl.edu/items/washington-university-in-st-louis-washu/ Annoyingly it also says not to use WUSTL any more.

Suggested change
associated with WASHU in any way. For example, an external institution
associated with WashU in any way. For example, an external institution

abstractions, this is the approach.
- Running the Immunogenomics workflow (immuno.wdl) manually and
assuming that your input data is stored on the compute1/storage1
system at WASHU: [immuno-compute1](https://github.com/griffithlab/immuno_gcp_wdl_compute1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
system at WASHU: [immuno-compute1](https://github.com/griffithlab/immuno_gcp_wdl_compute1)
system at WashU: [immuno-compute1](https://github.com/griffithlab/immuno_gcp_wdl_compute1)


1. [manual submission to Cromwell](https://github.com/wustl-oncology/cloud-workflows/blob/main/manual-workflows/README.md),
2. leveraging WUSTL's [GMS to automate interactions](https://github.com/wustl-oncology/cloud-workflows/tree/main/gms).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. leveraging WUSTL's [GMS to automate interactions](https://github.com/wustl-oncology/cloud-workflows/tree/main/gms).
2. leveraging WashU's [GMS to automate interactions](https://github.com/wustl-oncology/cloud-workflows/tree/main/gms).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants