Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): get capabilities should not happen during flow #225

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

rokam
Copy link
Collaborator

@rokam rokam commented Jul 10, 2024

PR Description

Reason & Detail

Device connect was called in a mock device when it shouldn't.

Related issue

It should fix raise of get capabilities on flow and get_keys.

fixes #221 #219

Copy link
Collaborator

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rokam rokam marked this pull request as ready for review July 10, 2024 20:02
@rokam rokam merged commit c29ab74 into master Jul 10, 2024
10 checks passed
@rokam rokam deleted the fix/config-auth branch July 10, 2024 20:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to serialize to JSON. Bad data found
2 participants