Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude de.json for pre-commit codespell check #64

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

wuwentao
Copy link
Owner

@wuwentao wuwentao commented Jun 4, 2024

PR Description

pre-commit codespell can't works for de.json
seems only one json file can't works now, just ignore this file in pre-commit config.

Reason & Detail

#60 PR can't pass pre-commit codespell, it should be an error.
just ignore this file

Related issue

fix #X

@chemelli74
Copy link
Collaborator

For now is fine, but we should switch to https://app.lokalise.com/

@wuwentao
Copy link
Owner Author

wuwentao commented Jun 4, 2024

For now is fine, but we should switch to https://app.lokalise.com/

got it, thank you, please help to approve, then we can merge #60

@wuwentao wuwentao requested review from chemelli74 and rokam June 4, 2024 13:19
@rokam rokam merged commit 709355e into master Jun 4, 2024
16 checks passed
@rokam rokam deleted the exclude_de_json branch June 4, 2024 13:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants