-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre release v0.1-rc1 #1
Conversation
Set the pre-release version to "v0.1-rc1".
Reviewer's Guide by SourceryThis pull request introduces the pre-release version v0.1-rc1 of GOES-DL, focusing on enhancing data access, improving usability, and expanding data support. The changes include updates to the build script, modifications to the AWS datasource, README updates, and the addition of a new example notebook for GridSat-B1 data. User journey diagram for downloading data with GOES-DLjourney
title User Journey for Downloading Data with GOES-DL
section Initialize Components
User -> ProductLocator: Import and initialize
User -> DatasourceAWS: Import and initialize with locator
User -> Downloader: Initialize with datasource and locator
section Download Data
User -> Downloader: Call get_files with start date
User -> Downloader: Call get_files with start and end dates
section Handle Results
User -> System: Receive data files or empty list
User -> System: Handle exceptions if any
Class diagram for DatasourceAWS changesclassDiagram
class DatasourceAWS {
+DatasourceCache cache
+create(locator: tuple[str, ...] | ProductLocator, life_time: float | None): DatasourceAWS
}
note for DatasourceAWS "Added static method create with overloads for different locator types"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wvenialbo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Remember to update the version number in init.py from 'v0.1-rc1' to the appropriate version number for the final release.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This pull request introduces the pre-release version v0.1-rc1 of GOES-DL. This release introduces several key features and improvements:
Summary by Sourcery
Release pre-release version v0.1-rc1 of GOES-DL with enhanced data access, improved usability, and expanded data support. Update build scripts to support various build options and add a new example notebook for GridSat-B1 data.
New Features:
Enhancements:
Build:
Documentation: