Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-sql: Unqualify outputColumns if AllColumns doesn't have qualifier #2764

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Feb 19, 2023

#2763 wasn't enough 🙇‍♂️

Unqualifying is also necessary if AllColumns doesn't have a qualifier.

@takezoe takezoe requested a review from xerial February 19, 2023 06:44
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #2764 (768c030) into master (aaa294a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2764      +/-   ##
==========================================
- Coverage   82.28%   82.27%   -0.01%     
==========================================
  Files         337      337              
  Lines       14178    14176       -2     
  Branches     2293     2340      +47     
==========================================
- Hits        11666    11663       -3     
- Misses       2512     2513       +1     
Impacted Files Coverage Δ
...in/scala/wvlet/airframe/sql/model/Expression.scala 72.75% <100.00%> (-0.18%) ⬇️
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 95.03% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa294a...768c030. Read the comment docs.

@xerial xerial added the bug label Feb 19, 2023
@xerial xerial merged commit d649138 into wvlet:master Feb 19, 2023
@takezoe takezoe deleted the sql-qualified-all-columns branch February 19, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants