airframe-sql: Remove unnecessary condition from AllColumns resolution #3061
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3061 +/- ##
==========================================
- Coverage 82.81% 82.80% -0.02%
==========================================
Files 350 350
Lines 14666 14665 -1
Branches 2448 2505 +57
==========================================
- Hits 12146 12143 -3
- Misses 2520 2522 +2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -463,7 +463,7 @@ object TypeResolver extends LogSupport { | |||
| case other => toResolvedAttribute(other.name, other) | |||
| } | |||
| List(a.copy(columns = Some((qualifier match { | |||
| case Some(q) => allColumns.filter(c => c.qualifier.contains(q) || c.tableAlias.contains(q)) | |||
| case Some(q) => allColumns.filter(_.tableAlias.contains(q)) | |||
There was a problem hiding this comment.
Good. This is because AllColumn.outputAttributes have both the qualifier and tableAlias
There was a problem hiding this comment.
This is because AllColumn.outputAttributes have both the qualifier and tableAlias
This is not accurate explanation.
Without this fix, we needed to check qualifiers for the following case but now this case is covered by tableAlias.
select t1.* from (select t1.time from A) t1On the other hand, checking qualifiers allows to resolve cases like below, but actually these are not valid SQL which means the current logic can resolve even invalid cases.
select A.* from (select A.time from A)
select t1.* from (select t1.time from A t1)
Follow up to #3057