Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd user service #1140

Closed
wants to merge 1 commit into from
Closed

Conversation

valeth
Copy link

@valeth valeth commented Sep 10, 2021

Adds a user service as an alternative way to autostart easyeffects.

@valeth valeth changed the title add systemd user service Add systemd user service Sep 10, 2021
@wwmm
Copy link
Owner

wwmm commented Sep 12, 2021

Although the change itself is simple I am afraid some users will enable this service and the switch in our menu at the same time. But what our menu setting does is creating an autostart file. In that case there will be two different places trying to autostart EasyEffects.

@valeth
Copy link
Author

valeth commented Sep 12, 2021

To avoid this we could query systemd via dbus and check if the unit is enabled/active, and then disable or enable the autostart option.

I think having systemd handle the process is overall more desirable, because it handles restarting in case of failure without having to have the window shown.

@Digitalone1
Copy link
Contributor

The problem of this solution is that we can't enable the service. It would be useful to enable and disable it on user choice, so maybe we could do it also for Flatpak users rather than trying to rely on libportal.

@vchernin
Copy link
Contributor

The problem of this solution is that we can't enable the service. It would be useful to enable and disable it on user choice, so maybe we could do it also for Flatpak users rather than trying to rely on libportal.

As far as I understand this wouldn’t be possible without poking a hole in the Flatpak sandbox. By design the only secure way to change things like this with Flatpak is through a portal. So there isn’t much benefit here at least for Flatpak as far as I can tell.

@wwmm
Copy link
Owner

wwmm commented Sep 14, 2021

To avoid this we could query systemd via dbus and check if the unit is enabled/active, and then disable or enable the autostart option.

Besides what has been said by Digitalone1 and vchernin if we use systemd API it will become a dependency. I like systemd. I have no problems with it. But there will be people complaining about this move. And things will be harder for people trying to get EasyEffects running on other systems like FreeBSD. At least in the past PulseEffects was able to run on it.

@polarathene
Copy link

Just a suggestion since it doesn't look like this has an intention to be merged. Perhaps rework it as a wiki addition instead?

Some users may discover it there and want that but not be familiar with how to configure the user service, so it could still be helpful.

@wwmm
Copy link
Owner

wwmm commented Aug 27, 2022

Perhaps rework it as a wiki addition instead?

I do not see any problem in having a systemd service step by step in the wiki.

@darkbasic
Copy link

Besides what has been said by Digitalone1 and vchernin if we use systemd API it will become a dependency

Well, it could be an optional one.

@wwmm
Copy link
Owner

wwmm commented Nov 24, 2022

Well, it could be an optional one.

Not without complicating even more some parts of our C++ code. As things are right now the setting Launch Service at System Startup already needs special handling for Flatpak through libportal. Supporting systemd too will only add more to the mess...

@valeth
Copy link
Author

valeth commented Jun 21, 2023

Been using the Flatpak version for a while and it's been working fine now.
So the systemd service solution isn't necessary anymore.

@valeth valeth closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants