-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expands platform support to include macOS, watchOS, and tvOS. #94
Conversation
…d by Morgan - MZ RAG Co-authored-by: Morgan Zellers <morgan.zellers@gmail.com>
EOD: Looks like the repo we are using to validate has something weird set up wrong in the Watch app for Cocoapods. When I converted @wiemerm 's project to a Cocoapod project, watch ran for me. We may consider dropping watchOS support in CocoaPods for now so we can push this out, but also we could fix it for 12.4. We could also just set the watch version high enough that you need 12.5 to use it? |
I would be up for dropping watch support from CocoaPods temporarily or bumping the version high enough to get past 12.4. I know @Tyler-Keith-Thompson had a few ideas yesterday of how to get around the XCTest build error. Maybe we could circle back with one of those approaches in the future |
Pushed a change that upped the watchOS version in the EDIT: Pipeline had the same issue, so I'm going to push a commit that removes support for watchOS from CocoaPods - we can discuss if we want to keep it or not in standup |
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage 94.70% 94.71%
=======================================
Files 62 62
Lines 1606 1608 +2
=======================================
+ Hits 1521 1523 +2
Misses 85 85
Continue to review full report at Codecov.
|
Regardless of whether CocoaPods remove(d/s) support for watchOS, we should consider bumping the Update: It doesn't appear possible. We can only select whole number versions. |
…or xcode 12.4 - MW RAG Co-authored-by: Megan Wiemer <megan.wiemer@wwt.com>
…elsewhere - MW RAG Co-authored-by: Megan Wiemer <megan.wiemer@wwt.com>
Things still missing in this, updating the supported versions doc (SECURITY.md). And we need the SPM validation step to actually validate these things as well. |
…spec because we can in SPM - RAG
… adding another line - TT RAG
EOD: I can't figure out how to use swift build to build against macOS and the same for trying to build against certain destinations. I would really want this to work: # Confirm OrchestrationResponders can build for their destinations
sh('xcodebuild -scheme SwiftCurrent_UIKit')
sh('xcodebuild -scheme SwiftCurrent_UIKit -sdk iphonesimulator -destination"platform=iOS Simulator,name=iPhone 12"')
sh('xcodebuild -scheme SwiftCurrent_UIKit -sdk appletvsimulator -destination"platform=tvOS Simulator,name=Apple TV"')
sh('xcodebuild -scheme SwiftCurrent_UIKit -sdk macosx -ARCHS="x86_64h" -destination"platform=macOS,variant=Mac Catalyst"')
sh('xcodebuild -scheme SwiftCurrent_UIKit -sdk iphonesimulator -destination"platform=macOS,variant=Mac Catalyst"') I have done a lot to try and curate things a little more into better testing. |
…is supported then all targets for common SDKs - RAG
…anding version support - RAG
Linked Issue:
Checklist: