Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove composition events that barely work on android #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cristianoccazinsp
Copy link

Thoughts on removing this? Composition events cause the following issues on Android:

  • Tapping enter at the very beginning (empty html), will end up adding text like "mytext
    another text
    " instead of using divs at the beginning.
  • It will also male ul/ol add extra spaces when tapping enter.

Note that tapping a space will "fix" this, but it would mean adding a space before every new line.

@Kirysha
Copy link

Kirysha commented Dec 14, 2022

i need these changes

@Kirysha
Copy link

Kirysha commented Dec 14, 2022

I propose to add a trigger that will allow you to disable this from RN component

@Kirysha
Copy link

Kirysha commented Dec 16, 2022

RichEditor supports html props, which was forgotten to be mentioned in the documentation. I moved the createHtml function to my project and modified it to solve this problem.

@stulip
Copy link
Member

stulip commented Apr 3, 2023

CompositionStart and CompositionEND is to deal with character issues such as Chinese, Japanese.

You can throw out the problems you encountered, and I think can it be compatible at the same time

@Kirysha
Copy link

Kirysha commented May 18, 2023

@stulip

Yes, I think you can add props to the config that will allow you to disable this feature depending on the language

@Kirysha
Copy link

Kirysha commented May 18, 2023

@stulip I added my idea to the pull request. You can watch this #314 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants