fixed empty content handling causing formatting issues with compositionend #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmatting on compositionend
josejimenezbuild
approved these changes
May 3, 2024
|
Are you able to merge? |
|
How can merge this PR? |
|
This repo hasn't been updated in over a year so I'm not sure 😅 @stulip could you check this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android I was having issues using lists, where deleting all text from the
contentand then typing was causingparagraphStatusto be permanently stuck at 1. This made the editor add extra divs oncompositionend, resulting in new list items getting wrapped in a div in a separate list, causing extra space between list items, and li inside ol to be stuck at 1.With this fix, the editor will detect when the
contentis empty/ user is typing directly into thecontentelement, and format it accordingly. This also preservesparagraphStatusfunctionality.