Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.ts to support MV2 runtime #1431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

harmonyharmo
Copy link

@harmonyharmo harmonyharmo commented Feb 13, 2025

Overview

Allow scripts to not register with manifest.json for MV2

Manual Testing

add scripts to not register with manifest.json for MV2. now it builds successfully.

Related Issue

This PR closes #1428

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 397d923
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67ae3179230d050008857825
😎 Deploy Preview https://deploy-preview-1431--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Feb 13, 2025

Open in Stackblitz

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1431

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1431

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1431

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1431

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1431

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1431

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1431

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1431

wxt

npm i https://pkg.pr.new/wxt@1431

commit: 397d923

@aklinker1
Copy link
Collaborator

@harmonyharmo We'll need to fix the failing tests, but in the meantime, can you try this out in your project? You can install your PR via:

npm i https://pkg.pr.new/wxt@1431

A
fix: improve error handling for user input validation
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (342057b) to head (397d923).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
- Coverage   81.34%   81.05%   -0.30%     
==========================================
  Files         128      128              
  Lines        6284     6276       -8     
  Branches     1069     1063       -6     
==========================================
- Hits         5112     5087      -25     
- Misses       1157     1174      +17     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow scripts to not register with manifest.json for MV2
2 participants