Use currentColor for fill
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a prop to disable it? I don't see much use case in disabling it. But someone might need to. |
|
You can add |
|
Ok cool!. Looks good. I didn't realize props would override like that. This should be released at the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm using this library with nuxt-lucide-icons which adds
stroke="currentColor"to the svg. This way, icons can be recolored in css by setting thecolorproperty of the svg. Right now the only way to change the color of an icon is in the markup, so I think settingfill="currentColor"would be really useful to allow this to be changed in CSS as well as generally following the current text color as a reasonable fallback