forked from rust-lang/rfcs
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request rust-lang#114 from knownasilya/template-lint
Add ember-cli-template-lint to default app & addon blueprints
- Loading branch information
Showing
1 changed file
with
34 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
- Start Date: 2018-01-04 | ||
- RFC PR: (leave this empty) | ||
|
||
# Summary | ||
|
||
Add https://github.com/rwjblue/ember-cli-template-lint as a default addon for the app and addon blueprints using the recommended rules. | ||
|
||
# Motivation | ||
|
||
Linting and security in templates would help not only individual developers write better apps with better accessibility and security, but would also help teams to be on the same page and stick to a handful of standards. | ||
|
||
# Detailed design | ||
|
||
1. Move ember-cli-template-lint to the ember-cli org (better for contributing and getting work off one person, @rwjblue) | ||
2. Add the dependency to the app blueprint here: https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json#L19 | ||
3. Also add it to the addon blueprint, like the eslint addon here: https://github.com/ember-cli/ember-cli/blob/master/blueprints/addon/index.js#L66 | ||
|
||
# How We Teach This | ||
|
||
The same way that we teach ESLint being on by default. | ||
|
||
# Drawbacks | ||
|
||
- More chatter in the terminal. | ||
- An additional dependency. | ||
- Recommended rules might not be good for everyone.. but that same issue probably exists with ESLint. | ||
|
||
# Alternatives | ||
|
||
Do nothing and have people write sub par template code. | ||
|
||
# Unresolved questions | ||
|
||
None |