Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#158615] Add grand total and subtotal to All Transactions page #4410

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

giladshanan
Copy link
Collaborator

@giladshanan giladshanan commented Jul 2, 2024

Release Notes

Adds subtotal to the paginated "All Transactions" page.
For filtered result sets with less than 1,000 transactions, also shows the Grand Total.

Otherwise shows an informational tooltip.
Screenshot 2024-07-09 at 1 56 27 PM

Screenshot 2024-07-09 at 1 56 24 PM

Additional Context

Accessibility

  • Did you scan for accessibility issues?
  • Did you check our accessibility goal checklist?
  • Did you add accessibility specs?

@giladshanan giladshanan marked this pull request as ready for review July 9, 2024 21:15
@giladshanan giladshanan requested a review from a team as a code owner July 9, 2024 21:15
@giladshanan
Copy link
Collaborator Author

@LeticiaErrandonea this is ready for a re-review.

I have confirmed that none of the repos are over-riding these color variables.
There are a couple of labels and buttons that will be a little darker shade of green, and the sidenav labels on the billing pages will now be black. Otherwise I don't expect any complications. No need for any additional testing here when you are preparing the release.

@giladshanan giladshanan merged commit a368bee into master Jul 11, 2024
3 checks passed
@giladshanan giladshanan deleted the 158615-all-transction-totals branch July 11, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants