Fix: [#162350] Clear cross core project when clearing cart #4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladshanan
approved these changes
Jul 17, 2024
| @@ -130,6 +130,7 @@ def clear_cart? | |||
| order_details.destroy_all | |||
There was a problem hiding this comment.
This method should probably not end with ? - maybe clear_cart instead?
There was a problem hiding this comment.
I think it may be related to it being used as a guard. Not sure, but I see the rest also follow that pattern
There was a problem hiding this comment.
👍🏼 good to merge then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes